Explicitly Disable Style/Encoding (support RuboCop >= 0.50.0)#25
Open
tonyta wants to merge 1 commit intojakeonrails:masterfrom
Open
Explicitly Disable Style/Encoding (support RuboCop >= 0.50.0)#25tonyta wants to merge 1 commit intojakeonrails:masterfrom
tonyta wants to merge 1 commit intojakeonrails:masterfrom
Conversation
As of RuboCop v0.50.0, the Style/Encoding cop is now enabled by default and configured to remove the encoding magic-comment. This deviates from the expected behavior in specs and changes the behavior of this gem. Disabling this cop will ensure that fix_db_schema_conflicts will output consistently regardless of RuboCop version. Change in RuboCop: rubocop/rubocop#4445
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of RuboCop v0.50.0, the Style/Encoding cop is now enabled by default and configured to remove the encoding magic-comment. This will strip the comment from the top of
db/schema.rb, deviating from the expected behavior.Disabling this cop will ensure that
fix_db_schema_conflictswill output consistently regardless of RuboCop version.This change was tested locally using RuboCop
0.49.1.0.50.0, and0.51.0.Before:
After: